[
https://issues.apache.org/jira/browse/HIVE-24918?focusedWorklogId=626367&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-626367
]
ASF GitHub Bot logged work on HIVE-24918:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jul/21 23:53
Start Date: 21/Jul/21 23:53
Worklog Time Spent: 10m
Work Description: hmangla98 commented on a change in pull request #2121:
URL: https://github.com/apache/hive/pull/2121#discussion_r674417976
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##########
@@ -173,22 +178,24 @@ public int execute() {
return
ErrorMsg.REPL_FAILED_WITH_NON_RECOVERABLE_ERROR.getErrorCode();
}
Path previousValidHiveDumpPath =
getPreviousValidDumpMetadataPath(dumpRoot);
- boolean isBootstrap = (previousValidHiveDumpPath == null);
- work.setBootstrap(isBootstrap);
+ work.setBootstrap(previousValidHiveDumpPath == null);
if (previousValidHiveDumpPath != null) {
work.setOldReplScope(new DumpMetaData(previousValidHiveDumpPath,
conf).getReplScope());
}
- //If no previous dump is present or previous dump is already loaded,
proceed with the dump operation.
- if (shouldDump(previousValidHiveDumpPath)) {
- Path currentDumpPath = getCurrentDumpPath(dumpRoot, isBootstrap);
+ boolean isPrevDumpFailoverReady =
checkFailoverStatus(previousValidHiveDumpPath);
Review comment:
checkFailoverStatus is used to examine valid dump dir (containing dump
ACK file) whereas in getCurrentDumpPath, we're probing the invalid dump dir
(meaning without dump ACK).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 626367)
Time Spent: 6h (was: 5h 50m)
> Handle failover case during Repl Dump
> -------------------------------------
>
> Key: HIVE-24918
> URL: https://issues.apache.org/jira/browse/HIVE-24918
> Project: Hive
> Issue Type: New Feature
> Reporter: Haymant Mangla
> Assignee: Haymant Mangla
> Priority: Major
> Labels: pull-request-available
> Time Spent: 6h
> Remaining Estimate: 0h
>
> To handle:
> a) Whenever user wants to go ahead with failover, during the next or
> subsequent repl dump operation upon confirming that there are no pending open
> transaction events, It should create a _failover_ready marker file in the
> dump dir. This marker file would contain scheduled query name
> that has generated this dump.
> b) Skip next repl dump instances once we have the marker file placed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
