[
https://issues.apache.org/jira/browse/HIVE-25200?focusedWorklogId=607745&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-607745
]
ASF GitHub Bot logged work on HIVE-25200:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/21 09:49
Start Date: 07/Jun/21 09:49
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2351:
URL: https://github.com/apache/hive/pull/2351#discussion_r646436391
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -265,9 +287,12 @@ public void
commitAlterTable(org.apache.hadoop.hive.metastore.api.Table hmsTable
HiveTableUtil.importFiles(preAlterTableProperties.tableLocation,
preAlterTableProperties.format,
partitionSpecProxy, preAlterTableProperties.partitionKeys,
catalogProperties, conf);
} else {
- Map<String, String> contextProperties = context.getProperties();
- if (contextProperties.containsKey(ALTER_TABLE_OPERATION_TYPE) &&
-
allowedAlterTypes.contains(contextProperties.get(ALTER_TABLE_OPERATION_TYPE))) {
+ if (isMatchingAlterOp(AlterTableType.ADDCOLS, context) && updateSchema
!= null) {
Review comment:
`updateSchema` can only be non-null if
`isMatchingAlterOp(AlterTableType.ADDCOLS, context)` was true in preAlterTable,
so maybe `if (updateSchema != null)` is enough here? That might make this part
also work generically for other schema update operations, like drop and rename,
since you just have to call `commit()` here regardless of the operation type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 607745)
Time Spent: 3h (was: 2h 50m)
> Alter table add columns support for Iceberg tables
> --------------------------------------------------
>
> Key: HIVE-25200
> URL: https://issues.apache.org/jira/browse/HIVE-25200
> Project: Hive
> Issue Type: Improvement
> Reporter: Ádám Szita
> Assignee: Ádám Szita
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Since Iceberg counts as being a non-native Hive table, addColumn operation
> needs to be implemented by the help of Hive meta hooks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
