[
https://issues.apache.org/jira/browse/HIVE-25200?focusedWorklogId=607734&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-607734
]
ASF GitHub Bot logged work on HIVE-25200:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/21 09:32
Start Date: 07/Jun/21 09:32
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2351:
URL: https://github.com/apache/hive/pull/2351#discussion_r646423854
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -310,6 +335,26 @@ public void
rollbackAlterTable(org.apache.hadoop.hive.metastore.api.Table hmsTab
}
}
+ private static boolean isSupportedAlterOperation(EnvironmentContext context)
{
+ for (Enum<?> op : SUPPORTED_ALTER_OPS) {
+ if (isMatchingAlterOp(op, context)) {
+ return true;
+ }
+ }
+ return false;
+ }
+
+ private static boolean isMatchingAlterOp(Enum<?> alterOperation,
EnvironmentContext context) {
+ if (context == null) {
Review comment:
these two null checks could be extracted into
`isSupportedAlterOperation`, since if they're null they'll always be false so
no need for looping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 607734)
Time Spent: 2h (was: 1h 50m)
> Alter table add columns support for Iceberg tables
> --------------------------------------------------
>
> Key: HIVE-25200
> URL: https://issues.apache.org/jira/browse/HIVE-25200
> Project: Hive
> Issue Type: Improvement
> Reporter: Ádám Szita
> Assignee: Ádám Szita
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Since Iceberg counts as being a non-native Hive table, addColumn operation
> needs to be implemented by the help of Hive meta hooks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
