[
https://issues.apache.org/jira/browse/HIVE-25200?focusedWorklogId=607740&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-607740
]
ASF GitHub Bot logged work on HIVE-25200:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/21 09:38
Start Date: 07/Jun/21 09:38
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2351:
URL: https://github.com/apache/hive/pull/2351#discussion_r646427858
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -213,7 +219,9 @@ public void
commitDropTable(org.apache.hadoop.hive.metastore.api.Table hmsTable,
@Override
public void preAlterTable(org.apache.hadoop.hive.metastore.api.Table
hmsTable, EnvironmentContext context)
throws MetaException {
- super.preAlterTable(hmsTable, context);
+ if (!isSupportedAlterOperation(context)) {
+ super.preAlterTable(hmsTable, context);
Review comment:
Since we've added ADDPROPS and DROPPROPS to our allowed list as well,
maybe we can remove the super call? It seems like it wouldn't add any
additional value at this point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 607740)
Time Spent: 2.5h (was: 2h 20m)
> Alter table add columns support for Iceberg tables
> --------------------------------------------------
>
> Key: HIVE-25200
> URL: https://issues.apache.org/jira/browse/HIVE-25200
> Project: Hive
> Issue Type: Improvement
> Reporter: Ádám Szita
> Assignee: Ádám Szita
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Since Iceberg counts as being a non-native Hive table, addColumn operation
> needs to be implemented by the help of Hive meta hooks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
