[ 
https://issues.apache.org/jira/browse/HIVE-24785?focusedWorklogId=552890&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-552890
 ]

ASF GitHub Bot logged work on HIVE-24785:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Feb/21 10:20
            Start Date: 16/Feb/21 10:20
    Worklog Time Spent: 10m 
      Work Description: pvargacl commented on a change in pull request #1979:
URL: https://github.com/apache/hive/pull/1979#discussion_r576708427



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -533,6 +533,10 @@ protected Boolean findNextCompactionAndExecute(boolean 
computeStats) throws Inte
         todo Find a more generic approach to collecting files in the same 
logical bucket to compact within the same
         task (currently we're using Tez split grouping).
         */
+        if (AcidUtils.isInsertOnlyTable(t.getParameters()) && !HiveConf
+            .getBoolVar(conf, HiveConf.ConfVars.HIVE_COMPACTOR_COMPACT_MM)) {
+          throw new HiveException("Insert only compaction is disabled. Set 
hive.compactor.compact.insert.only to true to enable it.");
+        }

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 552890)
    Time Spent: 1h 50m  (was: 1h 40m)

> Fix HIVE_COMPACTOR_COMPACT_MM property
> --------------------------------------
>
>                 Key: HIVE-24785
>                 URL: https://issues.apache.org/jira/browse/HIVE-24785
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Peter Varga
>            Assignee: Peter Varga
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Currently it will disable query based compaction for mm tables, but the 
> Worker will fall back to MR based compaction which is not implemented for mm 
> tables.
> This property should disable compaction in the Initiator



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to