[
https://issues.apache.org/jira/browse/HIVE-24785?focusedWorklogId=552873&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-552873
]
ASF GitHub Bot logged work on HIVE-24785:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Feb/21 09:23
Start Date: 16/Feb/21 09:23
Worklog Time Spent: 10m
Work Description: pvargacl commented on a change in pull request #1979:
URL: https://github.com/apache/hive/pull/1979#discussion_r576668055
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
##########
@@ -469,6 +469,12 @@ private boolean isEligibleForCompaction(CompactionInfo ci,
ShowCompactResponse c
"=true so we will not compact it.");
return false;
}
+ if (AcidUtils.isInsertOnlyTable(t.getParameters()) && !HiveConf
Review comment:
1. This switch is already there it will just cause ClassCastException,
rather than handle this properly
2. This customer is using MR based compaction which works fine, the problem
is for mm tables the system will run query based no matter what, we want to
turn off query based compaction for every table, until they can get the fix to
their cluster, which is a very valid thing to do, otherwise compaction will not
run for anything.
3. Using a switch like this until the upgrade is much better solution then
disabling it off for 1000+ tables manually
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 552873)
Time Spent: 1.5h (was: 1h 20m)
> Fix HIVE_COMPACTOR_COMPACT_MM property
> --------------------------------------
>
> Key: HIVE-24785
> URL: https://issues.apache.org/jira/browse/HIVE-24785
> Project: Hive
> Issue Type: Bug
> Reporter: Peter Varga
> Assignee: Peter Varga
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Currently it will disable query based compaction for mm tables, but the
> Worker will fall back to MR based compaction which is not implemented for mm
> tables.
> This property should disable compaction in the Initiator
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
