[
https://issues.apache.org/jira/browse/HIVE-24785?focusedWorklogId=552864&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-552864
]
ASF GitHub Bot logged work on HIVE-24785:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Feb/21 08:47
Start Date: 16/Feb/21 08:47
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on a change in pull request #1979:
URL: https://github.com/apache/hive/pull/1979#discussion_r576643788
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
##########
@@ -469,6 +469,12 @@ private boolean isEligibleForCompaction(CompactionInfo ci,
ShowCompactResponse c
"=true so we will not compact it.");
return false;
}
+ if (AcidUtils.isInsertOnlyTable(t.getParameters()) && !HiveConf
Review comment:
what kind of underlying bug? in most cases query based compaction is
used for full acid tables as well. this config looks like a real hack to ignore
the problem that over time could lead to a more serious issue with accumulated
data to be compacted and performance degradation. If we want to improve
compaction usability I don't think that's a good approach, but that's just my
10 cents. From code point of view patch looks good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 552864)
Time Spent: 1h 10m (was: 1h)
> Fix HIVE_COMPACTOR_COMPACT_MM property
> --------------------------------------
>
> Key: HIVE-24785
> URL: https://issues.apache.org/jira/browse/HIVE-24785
> Project: Hive
> Issue Type: Bug
> Reporter: Peter Varga
> Assignee: Peter Varga
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Currently it will disable query based compaction for mm tables, but the
> Worker will fall back to MR based compaction which is not implemented for mm
> tables.
> This property should disable compaction in the Initiator
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
