[
https://issues.apache.org/jira/browse/HIVE-24370?focusedWorklogId=511038&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-511038
]
ASF GitHub Bot logged work on HIVE-24370:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/20 20:44
Start Date: 12/Nov/20 20:44
Worklog Time Spent: 10m
Work Description: vnhive commented on a change in pull request #1664:
URL: https://github.com/apache/hive/pull/1664#discussion_r522414765
##########
File path:
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -1979,7 +1979,7 @@ struct GetPartitionsRequest {
4: optional bool withAuth,
5: optional string user,
6: optional list<string> groupNames,
- 7: GetPartitionsProjectionSpec projectionSpec
+ 7: GetProjectionsSpec projectionSpec
8: GetPartitionsFilterSpec filterSpec, // TODO not yet implemented. Must be
present but ignored
Review comment:
I generally thought it is forbidden to make changes unrelated to the
JIRA in a patch. Ofcourse this is a minor change and I will do as you suggest.
Thank you for the comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 511038)
Time Spent: 1h 50m (was: 1h 40m)
> Make the GetPartitionsProjectionSpec generic and add builder methods for
> tables and partitions in HiveMetaStoreClient
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-24370
> URL: https://issues.apache.org/jira/browse/HIVE-24370
> Project: Hive
> Issue Type: Task
> Reporter: Narayanan Venkateswaran
> Assignee: Narayanan Venkateswaran
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> HIVE-20306 defines a projection struct called GetPartitionsProjectionSpec
> While the name has Partition in its name, this is a fairly generic struct
> with nothing specific to partitions. This should be renamed to a more generic
> name (GetProjectionSpec ?) and builder methods of this class for tables and
> partitions must be added to HiveMetaStoreClient.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
