[
https://issues.apache.org/jira/browse/HIVE-24370?focusedWorklogId=510918&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-510918
]
ASF GitHub Bot logged work on HIVE-24370:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/20 17:27
Start Date: 12/Nov/20 17:27
Worklog Time Spent: 10m
Work Description: vineetgarg02 commented on a change in pull request
#1664:
URL: https://github.com/apache/hive/pull/1664#discussion_r522283921
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
##########
@@ -4664,6 +4664,58 @@ public void dropStoredProcedure(StoredProcedureRequest
request) throws MetaExcep
return client.get_all_stored_procedures(request);
}
+ /**
+ * Builder for the GetProjectionsSpec. This is a projection specification
for partitions returned from the HMS.
+ */
+ public static class GetPartitionProjectionsSpecBuilder {
Review comment:
Can we create a common interface implementing build and have both of the
classes implement it?
Is it possible to move the builder implementations to separate file?
HiveMetaStoreClient is already too big.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 510918)
Time Spent: 50m (was: 40m)
> Make the GetPartitionsProjectionSpec generic and add builder methods for
> tables and partitions in HiveMetaStoreClient
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-24370
> URL: https://issues.apache.org/jira/browse/HIVE-24370
> Project: Hive
> Issue Type: Task
> Reporter: Narayanan Venkateswaran
> Assignee: Narayanan Venkateswaran
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> HIVE-20306 defines a projection struct called GetPartitionsProjectionSpec
> While the name has Partition in its name, this is a fairly generic struct
> with nothing specific to partitions. This should be renamed to a more generic
> name (GetProjectionSpec ?) and builder methods of this class for tables and
> partitions must be added to HiveMetaStoreClient.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
