[
https://issues.apache.org/jira/browse/HIVE-24370?focusedWorklogId=510159&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-510159
]
ASF GitHub Bot logged work on HIVE-24370:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Nov/20 10:02
Start Date: 11/Nov/20 10:02
Worklog Time Spent: 10m
Work Description: vnhive opened a new pull request #1664:
URL: https://github.com/apache/hive/pull/1664
…lder methods for tables and partitions in HiveMetaStoreClient
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
HIVE-20306 defines a projection struct called GetPartitionsProjectionSpec
While the name has Partition in its name, this is a fairly generic struct with
nothing specific to partitions. This should be renamed to a more generic name
(GetProjectionSpec ?) and builder methods of this class for tables and
partitions must be added to HiveMetaStoreClient.
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
The changes in this JIRA will help reuse the projection specification for
projecting required table columns.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
There are no user facing changes in this patch.
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description, screenshot and/or a reproducable
example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
The existing tests ran. Since this was only the renaming of a class the fix
is expected to be non-intrusive.
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 510159)
Remaining Estimate: 0h
Time Spent: 10m
> Make the GetPartitionsProjectionSpec generic and add builder methods for
> tables and partitions in HiveMetaStoreClient
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-24370
> URL: https://issues.apache.org/jira/browse/HIVE-24370
> Project: Hive
> Issue Type: Task
> Reporter: Narayanan Venkateswaran
> Assignee: Narayanan Venkateswaran
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> HIVE-20306 defines a projection struct called GetPartitionsProjectionSpec
> While the name has Partition in its name, this is a fairly generic struct
> with nothing specific to partitions. This should be renamed to a more generic
> name (GetProjectionSpec ?) and builder methods of this class for tables and
> partitions must be added to HiveMetaStoreClient.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
