[ 
https://issues.apache.org/jira/browse/HIVE-23668?focusedWorklogId=447147&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-447147
 ]

ASF GitHub Bot logged work on HIVE-23668:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Jun/20 08:30
            Start Date: 17/Jun/20 08:30
    Worklog Time Spent: 10m 
      Work Description: pkumarsinha commented on a change in pull request #1129:
URL: https://github.com/apache/hive/pull/1129#discussion_r441373740



##########
File path: 
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
##########
@@ -981,9 +981,15 @@ public static ConfVars getMetaConf(String name) {
         + " and the frequency of persisting the metrics to persistent storage. 
"
       ),
     REPL_METRICS_UPDATE_FREQUENCY("metastore.repl.metrics.update.frequency",
-      "hive.repl.metrics.update.frequency", 1 /*1 minute */,
+      "hive.repl.metrics.update.frequency", 1, TimeUnit.MINUTES /*1 minute */,
       "Frequency at which replication Metrics will be stored in persistent 
storage. "
     ),
+    REPL_METRICS_CLEANUP_FREQUENCY("metastore.repl.metrics.cleanup.frequency",

Review comment:
       Yes, that would suffice. Mentioning the conf will help related which max 
age we are talking about.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 447147)
    Time Spent: 2h 10m  (was: 2h)

> Clean up Task for Hive Metrics
> ------------------------------
>
>                 Key: HIVE-23668
>                 URL: https://issues.apache.org/jira/browse/HIVE-23668
>             Project: Hive
>          Issue Type: Task
>            Reporter: Aasha Medhi
>            Assignee: Aasha Medhi
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-23668.01.patch, HIVE-23668.02.patch
>
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to