[
https://issues.apache.org/jira/browse/HIVE-23668?focusedWorklogId=447125&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-447125
]
ASF GitHub Bot logged work on HIVE-23668:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jun/20 08:07
Start Date: 17/Jun/20 08:07
Worklog Time Spent: 10m
Work Description: aasha commented on a change in pull request #1129:
URL: https://github.com/apache/hive/pull/1129#discussion_r441360163
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
##########
@@ -981,9 +981,15 @@ public static ConfVars getMetaConf(String name) {
+ " and the frequency of persisting the metrics to persistent storage.
"
),
REPL_METRICS_UPDATE_FREQUENCY("metastore.repl.metrics.update.frequency",
- "hive.repl.metrics.update.frequency", 1 /*1 minute */,
+ "hive.repl.metrics.update.frequency", 1, TimeUnit.MINUTES /*1 minute */,
"Frequency at which replication Metrics will be stored in persistent
storage. "
),
+ REPL_METRICS_CLEANUP_FREQUENCY("metastore.repl.metrics.cleanup.frequency",
Review comment:
A similar approach is followed by other clean up tasks as well. For
instance :
SCHEDULED_QUERIES_EXECUTION_MAINT_TASK_FREQUENCY("metastore.scheduled.queries.execution.maint.task.frequency",
"hive.metastore.scheduled.queries.execution.clean.frequency", 60,
TimeUnit.SECONDS,
"Interval of scheduled query maintenance task. Which removes
executions above max age;"
+ "and marks executions as timed out if the condition is met"),
SCHEDULED_QUERIES_EXECUTION_MAX_AGE("metastore.scheduled.queries.execution.max.age",
"hive.metastore.scheduled.queries.execution.max.age", 30 * 86400,
TimeUnit.SECONDS,
"Maximal age of a scheduled query execution entry before it is
removed."),
We need to document it. I think customers will understand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 447125)
Time Spent: 1h 10m (was: 1h)
> Clean up Task for Hive Metrics
> ------------------------------
>
> Key: HIVE-23668
> URL: https://issues.apache.org/jira/browse/HIVE-23668
> Project: Hive
> Issue Type: Task
> Reporter: Aasha Medhi
> Assignee: Aasha Medhi
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23668.01.patch, HIVE-23668.02.patch
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
