[ https://issues.apache.org/jira/browse/HIVE-23668?focusedWorklogId=447143&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-447143 ]
ASF GitHub Bot logged work on HIVE-23668: ----------------------------------------- Author: ASF GitHub Bot Created on: 17/Jun/20 08:27 Start Date: 17/Jun/20 08:27 Worklog Time Spent: 10m Work Description: aasha commented on a change in pull request #1129: URL: https://github.com/apache/hive/pull/1129#discussion_r441372090 ########## File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java ########## @@ -981,9 +981,15 @@ public static ConfVars getMetaConf(String name) { + " and the frequency of persisting the metrics to persistent storage. " ), REPL_METRICS_UPDATE_FREQUENCY("metastore.repl.metrics.update.frequency", - "hive.repl.metrics.update.frequency", 1 /*1 minute */, + "hive.repl.metrics.update.frequency", 1, TimeUnit.MINUTES /*1 minute */, "Frequency at which replication Metrics will be stored in persistent storage. " ), + REPL_METRICS_CLEANUP_FREQUENCY("metastore.repl.metrics.cleanup.frequency", Review comment: I have added that already that it removes metrics above the max age. I will add the config name as well. That should help I think. REPL_METRICS_CLEANUP_FREQUENCY("metastore.repl.metrics.cleanup.frequency", "hive.metastore.repl.metrics.cleanup.frequency", 1, TimeUnit.DAYS, "Interval of scheduled metrics clean up task. Which removes metrics above max age;"), REPL_METRICS_MAX_AGE("metastore.repl.metrics.max.age", "hive.metastore.repl.metrics.max.age", 7, TimeUnit.DAYS, "Maximal age of a replication metrics entry before it is removed."), ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 447143) Time Spent: 2h (was: 1h 50m) > Clean up Task for Hive Metrics > ------------------------------ > > Key: HIVE-23668 > URL: https://issues.apache.org/jira/browse/HIVE-23668 > Project: Hive > Issue Type: Task > Reporter: Aasha Medhi > Assignee: Aasha Medhi > Priority: Major > Labels: pull-request-available > Attachments: HIVE-23668.01.patch, HIVE-23668.02.patch > > Time Spent: 2h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)