[
https://issues.apache.org/jira/browse/HIVE-21884?focusedWorklogId=339480&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-339480
]
ASF GitHub Bot logged work on HIVE-21884:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Nov/19 16:44
Start Date: 06/Nov/19 16:44
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on pull request #794: HIVE-21884
URL: https://github.com/apache/hive/pull/794#discussion_r343173701
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/scheduled/ScheduledQueryExecutionService.java
##########
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.ql.scheduled;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.conf.HiveConf.ConfVars;
+import org.apache.hadoop.hive.metastore.api.QueryState;
+import org.apache.hadoop.hive.metastore.api.ScheduledQueryKey;
+import org.apache.hadoop.hive.metastore.api.ScheduledQueryPollResponse;
+import org.apache.hadoop.hive.metastore.api.ScheduledQueryProgressInfo;
+import org.apache.hadoop.hive.ql.DriverFactory;
+import org.apache.hadoop.hive.ql.IDriver;
+import org.apache.hadoop.hive.ql.processors.CommandProcessorException;
+import org.apache.hadoop.hive.ql.session.SessionState;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.annotations.VisibleForTesting;
+import com.google.common.util.concurrent.ThreadFactoryBuilder;
+
+public class ScheduledQueryExecutionService implements Closeable {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(ScheduledQueryExecutionService.class);
+
+ private ScheduledQueryExecutionContext context;
+ private ScheduledQueryExecutor worker;
+
+ public static ScheduledQueryExecutionService
startScheduledQueryExecutorService(HiveConf conf) {
+ MetastoreBasedScheduledQueryService qService = new
MetastoreBasedScheduledQueryService(conf);
+ ExecutorService executor =
+ Executors.newCachedThreadPool(
+ new
ThreadFactoryBuilder().setDaemon(true).setNameFormat("Scheduled Query Thread
%d").build());
+ ScheduledQueryExecutionContext ctx = new
ScheduledQueryExecutionContext(executor, conf, qService);
+ return new ScheduledQueryExecutionService(ctx);
+ }
+
+ public ScheduledQueryExecutionService(ScheduledQueryExecutionContext ctx) {
+ context = ctx;
+ ctx.executor.submit(worker = new ScheduledQueryExecutor());
+ ctx.executor.submit(new ProgressReporter());
+ }
+
+ static boolean isTerminalState(QueryState state) {
+ return state == QueryState.FINISHED || state == QueryState.ERRORED;
+ }
+
+ class ScheduledQueryExecutor implements Runnable {
+
+ private ScheduledQueryProgressInfo info;
+
+ @Override
+ public void run() {
+ while (true) {
+ ScheduledQueryPollResponse q =
context.schedulerService.scheduledQueryPoll();
+ if (q.isSetExecutionId()) {
+ try{
+ processQuery(q);
+ } catch (Throwable t) {
+ LOG.error("Unexpected exception during scheduled query
processing", t);
+ }
+ } else {
+ try {
+ Thread.sleep(context.getIdleSleepTime());
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ LOG.info("interrupted");
+ break;
+ }
+ }
+ }
+ }
+
+ public synchronized void reportQueryProgress() {
+ if (info != null) {
+ LOG.info("Reporting query progress of {} as {} err:{}",
info.getScheduledExecutionId(), info.getState(),
+ info.getErrorMessage());
+ context.schedulerService.scheduledQueryProgress(info);
+ if (isTerminalState(info.getState())) {
+ info = null;
+ }
+ }
+ }
+
+ private void processQuery(ScheduledQueryPollResponse q) {
+ SessionState state = null;
+ try {
+ HiveConf conf = new HiveConf(context.conf);
+ conf.setVar(ConfVars.HIVE_QUERY_EXCLUSIVE_LOCK,
lockNameFor(q.getScheduleKey()));
+ state = SessionState.start(conf);
+ info = new ScheduledQueryProgressInfo();
+ info.setScheduledExecutionId(q.getExecutionId());
+ info.setState(QueryState.EXECUTING);
+ reportQueryProgress();
+ try (
+ IDriver driver =
DriverFactory.newDriver(DriverFactory.getNewQueryState(conf), q.getUser(),
null)) {
Review comment:
I've tried this...and the result was less readable than the current one - so
I reverted back to this version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 339480)
Time Spent: 7h 40m (was: 7.5h)
> Scheduled query support
> -----------------------
>
> Key: HIVE-21884
> URL: https://issues.apache.org/jira/browse/HIVE-21884
> Project: Hive
> Issue Type: Improvement
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21844.04.patch, HIVE-21844.05.patch,
> HIVE-21844.06.patch, HIVE-21844.07.patch, HIVE-21844.08.patch,
> HIVE-21844.09.patch, HIVE-21844.15.patch, HIVE-21844.19.patch,
> HIVE-21844.21.patch, HIVE-21844.22.patch, HIVE-21884.01.patch,
> HIVE-21884.02.patch, HIVE-21884.03.patch, HIVE-21884.09.patch,
> HIVE-21884.10.patch, HIVE-21884.10.patch, HIVE-21884.11.patch,
> HIVE-21884.12.patch, HIVE-21884.13.patch, HIVE-21884.14.patch,
> HIVE-21884.14.patch, HIVE-21884.14.patch, HIVE-21884.16.patch,
> HIVE-21884.17.patch, HIVE-21884.18.patch, HIVE-21884.20.patch,
> HIVE-21884.23.patch, HIVE-21884.24.patch, HIVE-21884.25.patch,
> HIVE-21884.26.patch, Scheduled queries2.pdf
>
> Time Spent: 7h 40m
> Remaining Estimate: 0h
>
> design document:
> https://docs.google.com/document/d/1mJSFdJi_1cbxJTXC9QvGw2rQ3zzJkNfxOO6b5esmyCE/edit#
> in case the google doc is not reachable: [^Scheduled queries2.pdf]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
