[ https://issues.apache.org/jira/browse/HIVE-21884?focusedWorklogId=337183&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337183 ]
ASF GitHub Bot logged work on HIVE-21884: ----------------------------------------- Author: ASF GitHub Bot Created on: 01/Nov/19 04:49 Start Date: 01/Nov/19 04:49 Worklog Time Spent: 10m Work Description: jcamachor commented on pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r341450813 ########## File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ########## @@ -4773,7 +4778,24 @@ private static void populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal HIVE_QUERY_REEXECUTION_STATS_CACHE_SIZE("hive.query.reexecution.stats.cache.size", 100_000, "Size of the runtime statistics cache. Unit is: OperatorStat entry; a query plan consist ~100."), HIVE_QUERY_PLANMAPPER_LINK_RELNODES("hive.query.planmapper.link.relnodes", true, - "Wether to link Calcite nodes to runtime statistics."), + "Whether to link Calcite nodes to runtime statistics."), + + HIVE_SCHEDULED_QUERIES_EXECUTOR_ENABLED("hive.scheduled.queries.executor.enabled", true, + "Controls whether HS2 will run scheduled query executor."), + HIVE_SCHEDULED_QUERIES_NAMESPACE("hive.scheduled.queries.namespace", "hive", + "Sets the scheduled query namespace to be used. New scheduled queries are created in this namespace;" + + "and execution is also bound to the namespace"), + HIVE_SCHEDULED_QUERIES_EXECUTOR_IDLE_SLEEP_TIME("hive.scheduled.queries.executor.idle.sleep.time", "60s", + new TimeValidator(TimeUnit.SECONDS), + "Time to sleep between quering for the presence of a scheduled query."), + HIVE_SCHEDULED_QUERIES_EXECUTOR_PROGRESS_REPORT_INTERVAL("hive.scheduled.queries.executor.progress.report.interval", + "60s", + new TimeValidator(TimeUnit.SECONDS), + "While scheduled queries are in flight; " + + "a background update happens periodically to report the actual state of the query"), + HIVE_SECURITY_AUTHORIZATION_SCHEDULED_QUERIES_SUPPORTED("hive.security.authorization.scheduled.queries.supported", Review comment: Is this necessary? I am not sure how this code is working, but I guess I am wondering why do we need specifically this for schedules queries? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 337183) Time Spent: 7h 20m (was: 7h 10m) > Scheduled query support > ----------------------- > > Key: HIVE-21884 > URL: https://issues.apache.org/jira/browse/HIVE-21884 > Project: Hive > Issue Type: Improvement > Reporter: Zoltan Haindrich > Assignee: Zoltan Haindrich > Priority: Major > Labels: pull-request-available > Attachments: HIVE-21844.04.patch, HIVE-21844.05.patch, > HIVE-21844.06.patch, HIVE-21844.07.patch, HIVE-21844.08.patch, > HIVE-21844.09.patch, HIVE-21844.15.patch, HIVE-21844.19.patch, > HIVE-21844.21.patch, HIVE-21844.22.patch, HIVE-21884.01.patch, > HIVE-21884.02.patch, HIVE-21884.03.patch, HIVE-21884.09.patch, > HIVE-21884.10.patch, HIVE-21884.10.patch, HIVE-21884.11.patch, > HIVE-21884.12.patch, HIVE-21884.13.patch, HIVE-21884.14.patch, > HIVE-21884.14.patch, HIVE-21884.14.patch, HIVE-21884.16.patch, > HIVE-21884.17.patch, HIVE-21884.18.patch, HIVE-21884.20.patch, > HIVE-21884.23.patch, HIVE-21884.24.patch, HIVE-21884.25.patch, Scheduled > queries2.pdf > > Time Spent: 7h 20m > Remaining Estimate: 0h > > design document: > https://docs.google.com/document/d/1mJSFdJi_1cbxJTXC9QvGw2rQ3zzJkNfxOO6b5esmyCE/edit# > in case the google doc is not reachable: [^Scheduled queries2.pdf] -- This message was sent by Atlassian Jira (v8.3.4#803005)