[
https://issues.apache.org/jira/browse/HIVE-21884?focusedWorklogId=329838&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-329838
]
ASF GitHub Bot logged work on HIVE-21884:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/19 13:07
Start Date: 17/Oct/19 13:07
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on pull request #794: HIVE-21884
URL: https://github.com/apache/hive/pull/794#discussion_r335878812
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
##########
@@ -2066,6 +2074,71 @@ dropMaterializedViewStatement
: KW_DROP KW_MATERIALIZED KW_VIEW ifExists? viewName ->
^(TOK_DROP_MATERIALIZED_VIEW viewName ifExists?)
;
+createScheduledQueryStatement
+@init { pushMsg("create scheduled query statement", state); }
+@after { popMsg(state); }
+ : KW_CREATE KW_SCHEDULED KW_QUERY name=identifier
+ scheduleSpec
+ executedAsSpec?
Review comment:
it was totally wrong...I left this open this issue to also fix that
non-owner may modify - but it was working incorrectly.
how it will work:
* having `(CREATE|ALTER|DROP)_SCHEDULED_QUERY` controls if a user can use
scheduled queries
* the executed as is checked against admin
* if the current user is not the same as the scheduled query owner (and not
admin) alters should be denied.
these things happen in `ScheduledQueryAnalyze`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 329838)
Time Spent: 6h 40m (was: 6.5h)
> Scheduled query support
> -----------------------
>
> Key: HIVE-21884
> URL: https://issues.apache.org/jira/browse/HIVE-21884
> Project: Hive
> Issue Type: Improvement
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21844.04.patch, HIVE-21844.05.patch,
> HIVE-21844.06.patch, HIVE-21844.07.patch, HIVE-21844.08.patch,
> HIVE-21844.09.patch, HIVE-21844.15.patch, HIVE-21844.19.patch,
> HIVE-21844.21.patch, HIVE-21844.22.patch, HIVE-21884.01.patch,
> HIVE-21884.02.patch, HIVE-21884.03.patch, HIVE-21884.09.patch,
> HIVE-21884.10.patch, HIVE-21884.10.patch, HIVE-21884.11.patch,
> HIVE-21884.12.patch, HIVE-21884.13.patch, HIVE-21884.14.patch,
> HIVE-21884.14.patch, HIVE-21884.14.patch, HIVE-21884.16.patch,
> HIVE-21884.17.patch, HIVE-21884.18.patch, HIVE-21884.20.patch, Scheduled
> queries2.pdf
>
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
> design document:
> https://docs.google.com/document/d/1mJSFdJi_1cbxJTXC9QvGw2rQ3zzJkNfxOO6b5esmyCE/edit#
> in case the google doc is not reachable: [^Scheduled queries2.pdf]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
