[ 
https://issues.apache.org/jira/browse/HIVE-22323?focusedWorklogId=328164&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-328164
 ]

ASF GitHub Bot logged work on HIVE-22323:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Oct/19 21:26
            Start Date: 14/Oct/19 21:26
    Worklog Time Spent: 10m 
      Work Description: miklosgergely commented on pull request #813: 
HIVE-22323 Fix Desc Table bugs
URL: https://github.com/apache/hive/pull/813#discussion_r334367697
 
 

 ##########
 File path: ql/src/test/results/clientpositive/alterColumnStats.q.out
 ##########
 @@ -144,15 +144,35 @@ PREHOOK: Input: default@p_n0
 POSTHOOK: query: desc formatted p_n0 c1
 POSTHOOK: type: DESCTABLE
 POSTHOOK: Input: default@p_n0
-# col_name             data_type               comment                         
                                                         
 
 Review comment:
   Yes, it was intentional. I think it is much better to have a consistent 
output format for `desc formatted <table> <column>` like commands, showing the 
same table all the time, explicitly showing that we don't have statistics for 
the column, instead of showing the smaller table as if a `desc <table> 
<column>` command would have been executed. The previous form is only 
implicitly showing that there are no statistics, which can be misleading.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 328164)
    Time Spent: 1h  (was: 50m)

> Fix Desc Table bugs
> -------------------
>
>                 Key: HIVE-22323
>                 URL: https://issues.apache.org/jira/browse/HIVE-22323
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>         Attachments: HIVE-22323.01.patch, HIVE-22323.02.patch, 
> HIVE-22323.03.patch, HIVE-22323.04.patch, HIVE-22323.05.patch
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> DESC TABLE operation is having the following bugs:
>  # Whole table descs have two headers.
>  # Table column desc has incorrect long header, while the table is transposed 
> having the headers in the first column.
>  # Json formatted data also has the headers.
>  # Json formatted data doesn't have the column statistics in it.
>  # There is no TestBeeLineDriver test for desc table, thus the actual output 
> is not tested, just some intermediary.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to