[ 
https://issues.apache.org/jira/browse/HIVE-22323?focusedWorklogId=327660&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-327660
 ]

ASF GitHub Bot logged work on HIVE-22323:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Oct/19 08:11
            Start Date: 14/Oct/19 08:11
    Worklog Time Spent: 10m 
      Work Description: miklosgergely commented on pull request #813: 
HIVE-22323 Fix Desc Table bugs
URL: https://github.com/apache/hive/pull/813#discussion_r334364791
 
 

 ##########
 File path: ql/src/test/results/clientpositive/beeline/colstats_all_nulls.q.out
 ##########
 @@ -43,38 +43,38 @@ PREHOOK: Input: default@all_nulls
 POSTHOOK: query: describe formatted all_nulls a
 POSTHOOK: type: DESCTABLE
 POSTHOOK: Input: default@all_nulls
-col_name       a       NULL    NULL    NULL    NULL    NULL    NULL    NULL    
NULL    NULL    NULL
-data_type      bigint  NULL    NULL    NULL    NULL    NULL    NULL    NULL    
NULL    NULL    NULL
-min    0       NULL    NULL    NULL    NULL    NULL    NULL    NULL    NULL    
NULL    NULL
-max    0       NULL    NULL    NULL    NULL    NULL    NULL    NULL    NULL    
NULL    NULL
-num_nulls      5       NULL    NULL    NULL    NULL    NULL    NULL    NULL    
NULL    NULL    NULL
-distinct_count 1       NULL    NULL    NULL    NULL    NULL    NULL    NULL    
NULL    NULL    NULL
-avg_col_len            NULL    NULL    NULL    NULL    NULL    NULL    NULL    
NULL    NULL    NULL
-max_col_len            NULL    NULL    NULL    NULL    NULL    NULL    NULL    
NULL    NULL    NULL
-num_trues              NULL    NULL    NULL    NULL    NULL    NULL    NULL    
NULL    NULL    NULL
-num_falses             NULL    NULL    NULL    NULL    NULL    NULL    NULL    
NULL    NULL    NULL
-bitVector      HL      NULL    NULL    NULL    NULL    NULL    NULL    NULL    
NULL    NULL    NULL
-comment        from deserializer       NULL    NULL    NULL    NULL    NULL    
NULL    NULL    NULL    NULL    NULL
-COLUMN_STATS_ACCURATE  
{\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"a\":\"true\",\"b\":\"true\",\"c\":\"true\"}}
      NULL    NULL    NULL    NULL    NULL    NULL    NULL    NULL    NULL    
NULL
+col_name       a
+data_type      bigint
+min    0
+max    0
+num_nulls      5
+distinct_count 1
+avg_col_len    
+max_col_len    
+num_trues      
+num_falses     
+bit_vector     HL
+comment        from deserializer
+COLUMN_STATS_ACCURATE  
{\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"a\":\"true\",\"b\":\"true\",\"c\":\"true\"}}
 PREHOOK: query: describe formatted all_nulls b
 PREHOOK: type: DESCTABLE
 PREHOOK: Input: default@all_nulls
 POSTHOOK: query: describe formatted all_nulls b
 POSTHOOK: type: DESCTABLE
 POSTHOOK: Input: default@all_nulls
-col_name       b       NULL    NULL    NULL    NULL    NULL    NULL    NULL    
NULL    NULL    NULL
 
 Review comment:
   Yes. It was because the program has applied the long, detailed header for 
formatted desc for column data. These tables have 12 data, but they are 
transposed, so at the end they have only 2 columns. Still they were given the 
schema containing the 12 columns at the fetch task, which led to these tables 
with many empty columns. It was fixed in this patch.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 327660)
    Time Spent: 0.5h  (was: 20m)

> Fix Desc Table bugs
> -------------------
>
>                 Key: HIVE-22323
>                 URL: https://issues.apache.org/jira/browse/HIVE-22323
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>         Attachments: HIVE-22323.01.patch, HIVE-22323.02.patch, 
> HIVE-22323.03.patch, HIVE-22323.04.patch, HIVE-22323.05.patch
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> DESC TABLE operation is having the following bugs:
>  # Whole table descs have two headers.
>  # Table column desc has incorrect long header, while the table is transposed 
> having the headers in the first column.
>  # Json formatted data also has the headers.
>  # Json formatted data doesn't have the column statistics in it.
>  # There is no TestBeeLineDriver test for desc table, thus the actual output 
> is not tested, just some intermediary.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to