[ 
https://issues.apache.org/jira/browse/HIVE-22323?focusedWorklogId=328163&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-328163
 ]

ASF GitHub Bot logged work on HIVE-22323:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Oct/19 21:26
            Start Date: 14/Oct/19 21:26
    Worklog Time Spent: 10m 
      Work Description: miklosgergely commented on pull request #813: 
HIVE-22323 Fix Desc Table bugs
URL: https://github.com/apache/hive/pull/813#discussion_r334401590
 
 

 ##########
 File path: ql/src/test/results/clientpositive/autoColumnStats_5.q.out
 ##########
 @@ -202,19 +202,19 @@ PREHOOK: Input: default@partitioned1_n1
 POSTHOOK: query: desc formatted partitioned1_n1 partition(part=1) a
 POSTHOOK: type: DESCTABLE
 POSTHOOK: Input: default@partitioned1_n1
-col_name       data_type       min     max     num_nulls       distinct_count  
avg_col_len     max_col_len     num_trues       num_falses      bitvector       
comment
 
 Review comment:
   If there are no statistics available then there is the regular header added 
by TextMetaDataFormatter during the table creation, and still the fetch task 
adds the header with the statistics to the table. If there are statistics then 
TextMetaDataFormatter doesn't add any header, it transposes the table, and then 
the fetch task adds the long header - which is still bad. Both of these are 
fixed in the patch.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 328163)
    Time Spent: 1h  (was: 50m)

> Fix Desc Table bugs
> -------------------
>
>                 Key: HIVE-22323
>                 URL: https://issues.apache.org/jira/browse/HIVE-22323
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>         Attachments: HIVE-22323.01.patch, HIVE-22323.02.patch, 
> HIVE-22323.03.patch, HIVE-22323.04.patch, HIVE-22323.05.patch
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> DESC TABLE operation is having the following bugs:
>  # Whole table descs have two headers.
>  # Table column desc has incorrect long header, while the table is transposed 
> having the headers in the first column.
>  # Json formatted data also has the headers.
>  # Json formatted data doesn't have the column statistics in it.
>  # There is no TestBeeLineDriver test for desc table, thus the actual output 
> is not tested, just some intermediary.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to