[ 
https://issues.apache.org/jira/browse/HBASE-18843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183624#comment-16183624
 ] 

Appy commented on HBASE-18843:
------------------------------

Thanks a lot [~elserj] for prompt back-and-forth! Yeah, let's revert it for now.

I looked around a bit more, and maybe have a more elegant solution.
Just override {{protected void doBuildListing(Path pathToListingFile, 
DistCpContext context) throws IOException }} which is marked protected, so is 
meant to be.
For each path, do path=path.getParent() for 1 less time than is being done in 
current {{computeSourceRootPath}}. Set the context appropriately so that the 
default implementation of {{computeSourceRootPath}} does one more 
path.getParent. And that should be enough!


> Add DistCp support to incremental backup with bulk loading
> ----------------------------------------------------------
>
>                 Key: HBASE-18843
>                 URL: https://issues.apache.org/jira/browse/HBASE-18843
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-18843-v1.patch, HBASE-18843-v2.patch, 
> HBASE-18843-v4.patch, HBASE-18843-v5.patch
>
>
> Currently, we copy bulk loaded files to backup one-by-one on a client side 
> (where backup create runs). This has to be replaced with DistCp copying.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to