[
https://issues.apache.org/jira/browse/HBASE-18843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183613#comment-16183613
]
Appy commented on HBASE-18843:
------------------------------
I guess followup is fine.
But i have a bigger question, why is this class such almost duplicate of
SimpleCopyListing. I see that [~tedyu] also raised that question and the answer
was - need to overwrite {{computeSourceRootPath}}. But why?
And if so, all you needed was to just override the only method which actually
calls it - {{public void doBuildListing(SequenceFile.Writer fileListWriter,
DistCpContext options) throws IOException}}
I spent sometime looking around. I see the class is dynamically loaded by
setting a conf. When does it come into picture?
Can we do the custom logic before triggering copy, and inject it somehow?
In any case, it's not good that such a blatant copy of code got checked in and
the class doesn't have a big fat comment explaining 'Why the need? What's was
the exact pain point?, etc etc'.
> Add DistCp support to incremental backup with bulk loading
> ----------------------------------------------------------
>
> Key: HBASE-18843
> URL: https://issues.apache.org/jira/browse/HBASE-18843
> Project: HBase
> Issue Type: Improvement
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18843-v1.patch, HBASE-18843-v2.patch,
> HBASE-18843-v4.patch, HBASE-18843-v5.patch
>
>
> Currently, we copy bulk loaded files to backup one-by-one on a client side
> (where backup create runs). This has to be replaced with DistCp copying.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
