Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2509#discussion_r101231413
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
---
@@ -633,7 +654,12 @@ public void runStartFromGroupOffsets() throws
Exception {
readProps.setProperty("auto.offset.reset", "earliest");
// the committed group offsets should be used as starting points
- KafkaTestEnvironment.KafkaOffsetHandler kafkaOffsetHandler =
kafkaServer.createOffsetHandler(standardProps);
+ Properties offsetHandlerProps = new Properties();
+ offsetHandlerProps.putAll(standardProps);
+ offsetHandlerProps.setProperty("key.deserializer",
"org.apache.kafka.common.serialization.ByteArrayDeserializer");
+ offsetHandlerProps.setProperty("value.deserializer",
"org.apache.kafka.common.serialization.ByteArrayDeserializer");
--- End diff --
Doesn't it make sense to set these properties once in the
`KafkaOffsetHandlerImpl` instead of all locations where the offset handler is
being created?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
