Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2509#discussion_r101051496
  
    --- Diff: 
flink-connectors/flink-connector-kafka-0.10/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
 ---
    @@ -229,6 +231,8 @@ public void prepare(int numKafkaServers, Properties 
additionalServerProperties,
                standardProps.setProperty("zookeeper.connect", 
zookeeperConnectionString);
                standardProps.setProperty("bootstrap.servers", 
brokerConnectionString);
                standardProps.setProperty("group.id", "flink-tests");
    +           standardProps.setProperty("key.deserializer", 
"org.apache.kafka.common.serialization.ByteArrayDeserializer");
    +           standardProps.setProperty("value.deserializer", 
"org.apache.kafka.common.serialization.ByteArrayDeserializer");
    --- End diff --
    
    Perhaps I should move this out of the `standardProps` and set them in those 
tests only.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to