Martijn Visser created FLINK-40979:
--------------------------------------

             Summary: HashAggITCase only runs its inherited tests without 
adaptive local hash aggregation
                 Key: FLINK-40979
                 URL: https://issues.apache.org/jira/browse/FLINK-40979
             Project: Flink
          Issue Type: Bug
          Components: Table SQL / Planner, Tests
            Reporter: Martijn Visser
            Assignee: Martijn Visser


Since the JUnit 5 migration in FLINK-32059, {{HashAggITCase}} runs the tests it 
inherits from {{AggregateITCaseBase}} only with {{adaptiveLocalHashAggEnable}} 
set to false. They are plain {{@Test}} methods, so 
{{ParameterizedTestExtension}} doesn't apply, and {{prepareAggOp()}} never 
enables adaptive local hash aggregation for them. Under JUnit 4 they ran for 
both values.

We should run the inherited tests with it enabled again, for example through a 
subclass. Found while looking at FLINK-40971.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to