Martijn Visser created FLINK-40981:
--------------------------------------

             Summary: ParameterizedTestExtension should fail tests that it does 
not parameterize
                 Key: FLINK-40981
                 URL: https://issues.apache.org/jira/browse/FLINK-40981
             Project: Flink
          Issue Type: Technical Debt
          Components: Tests
            Reporter: Martijn Visser
            Assignee: Martijn Visser


{{ParameterizedTestExtension}} only parameterizes {{@TestTemplate}} methods. A 
plain {{@Test}} in a class with {{@Parameter}} fields runs once with default 
field values and nothing reports it, which is how FLINK-40971, FLINK-40979 and 
FLINK-40980 went unnoticed. The JUnit 4 runner also rejected duplicate or 
unused {{@Parameter}} indices and rows of the wrong length, and the port 
dropped those checks.

We should make the extension fail a test that isn't a {{@TestTemplate}} in such 
a class and validate indices and row length again. Tests in such classes that 
are deliberately not parameterized need to move out, or run per parameter where 
that adds coverage, first.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to