1996fanrui commented on code in PR #29189:
URL: https://github.com/apache/flink/pull/29189#discussion_r4036206014
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/RecoveredChannelStateHandler.java:
##########
@@ -592,7 +592,7 @@ public void recover(
channelInfo.getGateIdx(),
oldSubtaskIndex,
channelInfo.getInputChannelIdx(),
- buffer.retainBuffer(),
+ buffer,
Review Comment:
Agreed. Ownership stays intact here — the buffer is still recycled by
close() → clear(); it's only a free-vs-recycle ordering window on the
already-failing teardown path, with no leak or lasting effect. Leaving it as a
follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
