1996fanrui opened a new pull request, #29189:
URL: https://github.com/apache/flink/pull/29189
## What is the purpose of the change
During checkpointing-during-recovery,
`SpillingWithFilteringHandler.recover()` retains the
pre-filter buffer at the call site, before `segmentSerializerFor()` and the
`ChannelStateFilteringHandler` dispatcher's early throws (invalid gateIndex
/ null gate
handler) run. Any of those throws orphans the retained reference, so its
refCount never
reaches 0 and `closeInternal()` later `free()`s a `MemorySegment` still
wrapped by a live
`NetworkBuffer`.
## Brief change log
- `recover()` passes the base buffer instead of `buffer.retainBuffer()`.
- The retain now happens where the dispatcher delegates to the inner
`GateFilterHandler`,
whose `sourceBufferOwnershipTransferred` guard already recycles on throw.
## Verifying this change
Added
`InputChannelRecoveredStateHandlerTest#testPreFilterBufferRecycledWhenFilterAndRewriteThrows`:
asserts the pre-filter buffer is recycled when `filterAndRewrite` throws.
Fails before the fix,
passes after.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
