1996fanrui commented on code in PR #29189:
URL: https://github.com/apache/flink/pull/29189#discussion_r4036042720
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateFilteringHandler.java:
##########
@@ -133,7 +133,7 @@ public void filterAndRewrite(
+ ". This gate is not a network input and should
not have recovered buffers.");
}
gateHandler.filterAndRewrite(
- oldSubtaskIndex, oldChannelIndex, sourceBuffer,
outputSerializer);
+ oldSubtaskIndex, oldChannelIndex, sourceBuffer.retainBuffer(),
outputSerializer);
Review Comment:
Went with your symmetric alternative: hoisted `segmentSerializerFor` before
the retain, and both early throws now `recycle sourceBuffer`. Both overloads
consume the buffer again; the ownership test is restored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
