1996fanrui commented on PR #28661: URL: https://github.com/apache/flink/pull/28661#issuecomment-5209491522
> One more thing found while reading, flagged here instead of inline since it isn't part of this diff (pre-existing from #28651, in `FilteringHandler.recoverWithFiltering`'s catch block): `onRecoveredStateBuffer` only throws after the buffer's ownership has already transferred into the channel's queue, so the catch loop's `for (int j = i; j < filteredBuffers.size(); j++)` recycles the buffer at index `i` while it's already live in that queue. Might be worth a fix there (starting at `j = i + 1`), separately from this PR. Hey @rkhachatryan , good catch, created a separate pr to fix it https://github.com/apache/flink/pull/28936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
