1996fanrui commented on code in PR #28661:
URL: https://github.com/apache/flink/pull/28661#discussion_r3732107287
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/SequentialChannelStateReaderImpl.java:
##########
@@ -110,7 +111,7 @@ public Optional<FetchedChannelState> readInputData(
// only signals "there is state to recover". The spilling backend
returns a real,
// file-backed container here.
Review Comment:
Exactly the next PR's version, but it would fail here.
The in-memory handlers produce nothing, so it always returns empty;
StreamTask then passes `needsRecovery=false` to requestPartitions, and
`RecoveredInputChannel#toInputChannel `asserts `receivedBuffers.isEmpty() `—
which the in-memory handler just filled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
