jlalwani-amazon commented on code in PR #39:
URL:
https://github.com/apache/flink-connector-hive/pull/39#discussion_r3242383877
##########
flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectITCase.java:
##########
@@ -295,8 +295,8 @@ public void testCreateTable() throws Exception {
}
@Test
- public void testCreateTableWithConstraints() throws Exception {
- Assume.assumeTrue(HiveVersionTestUtil.HIVE_310_OR_LATER);
+ void testCreateTableWithConstraints() throws Exception {
+ Assumptions.assumeTrue(HiveVersionTestUtil.HIVE_310_OR_LATER);
Review Comment:
ok. I tried to keep the same convention as existing code. I'll fix in next
commit.
Do we have any other coding conventions besides checkstyle that I should be
aware about?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
