jlalwani-amazon commented on code in PR #39:
URL:
https://github.com/apache/flink-connector-hive/pull/39#discussion_r3242496593
##########
flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveCatalogITCase.java:
##########
@@ -250,7 +252,12 @@ public void testReadWriteCsv() throws Exception {
"WITH ('connector.type' =
'filesystem','connector.path' = 'file://%s','format.type' = 'csv')",
srcPath));
- String sinkPath = new File(tempFolder.newFolder(),
"csv-order-sink").toURI().toString();
+ String sinkPath =
+ new File(
+
Files.createDirectories(tempFolder.resolve("csvSink")).toFile(),
Review Comment:
Pulling this code into a util method won't reduce the code too much. Because
we will need to do something like `FilesUtil.createSubDir(tempFolder,
"csvSink")` instead of
`Files.createDirectories(tempFolder.resolve("csvSink")).toFile()`.
Alternatively, we can pull the tempdir into a extension, but it seems
overkill for one line of code.
I'll pull the `createSubDir` into a common util class in next commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
