snuyanzin commented on code in PR #39:
URL:
https://github.com/apache/flink-connector-hive/pull/39#discussion_r3224085906
##########
flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/TableEnvHiveConnectorITCase.java:
##########
@@ -583,7 +583,7 @@ public void testLocationWithComma() throws Exception {
assertThat(results.toString()).isEqualTo("[+I[1], +I[2]]");
// test partition location
tableEnv.executeSql("create table tbl2 (x int) partitioned by (p
string)");
- location = tempFolder.newFolder(",");
+ location =
Files.createDirectories(tempFolder.resolve(",")).toFile();
Review Comment:
we have such line in multiple places.
Should we extract it in a util method and reuse in a shorter manner?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
