snuyanzin commented on code in PR #39:
URL:
https://github.com/apache/flink-connector-hive/pull/39#discussion_r3221562670
##########
flink-connector-hive/pom.xml:
##########
@@ -44,6 +44,8 @@ under the License.
<hive.hadoop.version>2.10.2</hive.hadoop.version>
<hiverunner.version>4.0.0</hiverunner.version>
<reflections.version>0.9.8</reflections.version>
+ <!-- Allow tests to run on Java 17+ where Hive uses deep
reflection on java.base internals -->
+ <flink.surefire.baseArgLine>-XX:+UseG1GC -Xms256m --add-opens
java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.net=ALL-UNNAMED
--add-opens java.base/java.nio=ALL-UNNAMED --add-opens
java.base/java.util=ALL-UNNAMED --add-opens
java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens
java.base/java.time=ALL-UNNAMED --add-exports
java.security.jgss/sun.security.krb5=ALL-UNNAMED</flink.surefire.baseArgLine>
Review Comment:
instead of putting everything in one heap can we also put a comment for each
flag: what test requires it?
similar things we have in flink main repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
