Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r96413755
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSingleRowJoin.scala
---
@@ -144,21 +150,46 @@ class DataSetSingleRowJoin(
val condition = codeGenerator.generateExpression(joinCondition)
- val joinMethodBody = s"""
- |${condition.code}
- |if (${condition.resultTerm}) {
- | ${conversion.code}
- |
${codeGenerator.collectorTerm}.collect(${conversion.resultTerm});
- |}
- |""".stripMargin
+ val joinMethodBody =
+ if (joinType == JoinRelType.INNER) {
+ s"""
+ |${condition.code}
+ |if (${condition.resultTerm}) {
+ | ${conversion.code}
+ |
${codeGenerator.collectorTerm}.collect(${conversion.resultTerm});
+ |}
+ |""".stripMargin
+ } else {
+ val singleNode =
--- End diff --
can be shorted to `val singleNode = if (leftIsSingle) leftNode else
rightNode`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
