Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3033#discussion_r96409192
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/MapJoinLeftRunner.scala
 ---
    @@ -32,6 +33,17 @@ class MapJoinLeftRunner[IN1, IN2, OUT](
         broadcastSet match {
           case Some(singleInput) => function.join(multiInput, singleInput, out)
           case None =>
    --- End diff --
    
    I would add an additional condition here and check if we execute an inner 
or an outer join.
    For that I would add another constructor parameter with a boolean flag 
`isOuterJoin` to indicate that this is an outer join (multiInput is outer side).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to