loserwang1024 commented on code in PR #4004:
URL: https://github.com/apache/flink-cdc/pull/4004#discussion_r2061980832
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/main/java/org/apache/flink/cdc/connectors/postgres/source/utils/TableDiscoveryUtils.java:
##########
@@ -38,7 +38,8 @@ public static List<TableId> listTables(
throws SQLException {
Set<TableId> allTableIds =
- jdbc.readTableNames(database, null, null, new String[]
{"TABLE"});
Review Comment:
I hope we can add a param such as partitioned(maybe we can check whether
debezium has, so we can reuse), when this param is enabled:
1. discovery partition table here.
2. add publish_via_partition_root=true when create publication.We can add a
initRootPublication like what
io.debezium.connector.postgresql.connection.PostgresReplicationConnection#initPublication
does or just modify this method. (But this class is copy from debezium, too
much difference is not recommanded)
Though it's enough to read partition table now. But user have to create
publication in advance.
To be honest, I hope debezium helps do it. But if it lacks it, we can do it
to make easier for user.
Just my own thought,
@phamvinh1712 @leonardBang , What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
