phamvinh1712 commented on code in PR #4004:
URL: https://github.com/apache/flink-cdc/pull/4004#discussion_r2062637449
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/main/java/org/apache/flink/cdc/connectors/postgres/source/utils/TableDiscoveryUtils.java:
##########
@@ -38,7 +38,8 @@ public static List<TableId> listTables(
throws SQLException {
Set<TableId> allTableIds =
- jdbc.readTableNames(database, null, null, new String[]
{"TABLE"});
Review Comment:
I know that debezium doesn't create publication with
`publish_via_partition_root=true` and users will need to create it themselves
in advance.
I agree with you that if we do it it will help users, but i'm afraid it will
make us hard to upgrade debezium version (which i believe we need to do at some
points since flink-cdc is using an old version of debezium 1.9.6)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
