loserwang1024 commented on code in PR #4004:
URL: https://github.com/apache/flink-cdc/pull/4004#discussion_r2061980832


##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/main/java/org/apache/flink/cdc/connectors/postgres/source/utils/TableDiscoveryUtils.java:
##########
@@ -38,7 +38,8 @@ public static List<TableId> listTables(
             throws SQLException {
 
         Set<TableId> allTableIds =
-                jdbc.readTableNames(database, null, null, new String[] 
{"TABLE"});

Review Comment:
   I hope we can add a param such as partitioned(maybe we can check whether 
debezium has, so we can reuse), when this param is enabled:
   1. discovery table here.
   2. add publish_via_partition_root=true when create publication in 
io.debezium.connector.postgresql.connection.PostgresReplicationConnection#initPublication.
   
   To be honest, I hope debezium helps do it. But if it lacks it, we can do it 
to make easier for user.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to