loserwang1024 commented on code in PR #3988:
URL: https://github.com/apache/flink-cdc/pull/3988#discussion_r2055819823
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/assigner/HybridSplitAssigner.java:
##########
@@ -252,56 +260,106 @@ public void close() throws IOException {
}
//
--------------------------------------------------------------------------------------------
-
- public StreamSplit createStreamSplit() {
- final List<SchemalessSnapshotSplit> assignedSnapshotSplit =
- snapshotSplitAssigner.getAssignedSplits().values().stream()
- .sorted(Comparator.comparing(SourceSplitBase::splitId))
- .collect(Collectors.toList());
-
- Map<String, Offset> splitFinishedOffsets =
snapshotSplitAssigner.getSplitFinishedOffsets();
- final List<FinishedSnapshotSplitInfo> finishedSnapshotSplitInfos = new
ArrayList<>();
-
- Offset minOffset = null, maxOffset = null;
- for (SchemalessSnapshotSplit split : assignedSnapshotSplit) {
- // find the min and max offset of change log
- Offset changeLogOffset = splitFinishedOffsets.get(split.splitId());
- if (minOffset == null || changeLogOffset.isBefore(minOffset)) {
- minOffset = changeLogOffset;
+ // Overridable methods
Review Comment:
Why variable is not put into begining? And I don't unstand what's
Overridable methods meaning here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
