yuxiqian commented on PR #3988:
URL: https://github.com/apache/flink-cdc/pull/3988#issuecomment-2804819638

   Thanks for @loserwang1024's kindly review. My answers:
   
   * We don't have any incremental snapshot source that supports multiple 
StreamSplits for now, so I'll add some mocking tests here.
   
   * The transition of assigning status should not change, the only difference 
would be the amount of streaming splits assigned.
   
   * An exception will be thrown since there won't be enough splits. Extra 
checking could also be added from the source side to fail in the config 
validation phase.
   
   ```java
   Preconditions.checkArgument(
        pendingStreamSplits.size() <= enumeratorContext.currentParallelism(),
        "%s stream splits generated, which is greater than current parallelism 
%s. Some splits might never be assigned.",
        pendingStreamSplits.size(),
        enumeratorContext.currentParallelism());
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to