loserwang1024 commented on code in PR #3988:
URL: https://github.com/apache/flink-cdc/pull/3988#discussion_r2055650071
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/enumerator/IncrementalSourceEnumerator.java:
##########
@@ -172,7 +181,7 @@ public void handleSourceEvent(int subtaskId, SourceEvent
sourceEvent) {
LOG.info(
"The enumerator receives notice from subtask {} for the
stream split assignment. ",
subtaskId);
- this.streamSplitTaskId = subtaskId;
Review Comment:
1. Use set rather than list? 2. What if the stream split's taskId changed
because addSplitBack or something else? I remember @ruanhang use to mention it
when I intruduce newly added framework.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
