[ 
https://issues.apache.org/jira/browse/FLINK-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15769662#comment-15769662
 ] 

Fabian Hueske commented on FLINK-5256:
--------------------------------------

Can you point me to a branch that you used to run the test?

Most likely the issue is that the joinType is not respected.
An inner join does only produce results if there is are two tuples from each 
side with a matching join condition. Hence, tuples which do not find at least 
on matching tuple of the other side are removed.
A left outer join preserves all tuples of the left side and fills the 
attributes of the missing right tuple with nulls.

We need to change the runtime code to call the join function also if the 
singleRow input is empty (null) and change the generated code to handle a null 
input record.

> Extend DataSetSingleRowJoin to support Left and Right joins
> -----------------------------------------------------------
>
>                 Key: FLINK-5256
>                 URL: https://issues.apache.org/jira/browse/FLINK-5256
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.2.0
>            Reporter: Fabian Hueske
>            Assignee: Anton Mushin
>
> The {{DataSetSingleRowJoin}} is a broadcast-map join that supports arbitrary 
> inner joins where one input is a single row.
> I found that Calcite translates certain subqueries into non-equi left and 
> right joins with single input. These cases can be handled if the  
> {{DataSetSingleRowJoin}} is extended to support outer joins on the 
> non-single-row input, i.e., left joins if the right side is single input and 
> vice versa.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to