[ 
https://issues.apache.org/jira/browse/FLINK-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764285#comment-15764285
 ] 

ASF GitHub Bot commented on FLINK-5256:
---------------------------------------

GitHub user ex00 opened a pull request:

    https://github.com/apache/flink/pull/3033

    [FLINK-5256] Extend DataSetSingleRowJoin to support Left and Right joins

    add support outer joins with single record via DataSetSingleRowJoin
    
    Thanks for contributing to Apache Flink. Before you open your pull request, 
please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your 
pull request. For more information and/or questions please refer to the [How To 
Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful 
description of your changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira 
title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the 
JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis 
build has passed
    
    Hi,
    outer joins with single record is supported via ``DataSetSingleRowJoin`` 
and simultaneously outer joins with many  records is supported via 
``DataSetJoin``

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ex00/flink FLINK-5256

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3033.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3033
    
----
commit eeb8863c9eb77e8484a5f839339cf6aa378b1fe6
Author: Anton Mushin <anton_mus...@epam.com>
Date:   2016-12-20T13:33:36Z

    [FLINK-5256] Extend DataSetSingleRowJoin to support Left and Right joins
    
    add support outer joins with single record via DataSetSingleRowJoin

----


> Extend DataSetSingleRowJoin to support Left and Right joins
> -----------------------------------------------------------
>
>                 Key: FLINK-5256
>                 URL: https://issues.apache.org/jira/browse/FLINK-5256
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.2.0
>            Reporter: Fabian Hueske
>
> The {{DataSetSingleRowJoin}} is a broadcast-map join that supports arbitrary 
> inner joins where one input is a single row.
> I found that Calcite translates certain subqueries into non-equi left and 
> right joins with single input. These cases can be handled if the  
> {{DataSetSingleRowJoin}} is extended to support outer joins on the 
> non-single-row input, i.e., left joins if the right side is single input and 
> vice versa.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to