[
https://issues.apache.org/jira/browse/FLINK-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15767567#comment-15767567
]
ASF GitHub Bot commented on FLINK-5256:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3033#discussion_r93472610
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetSingleRowJoinRule.scala
---
@@ -35,16 +35,7 @@ class DataSetSingleRowJoinRule
override def matches(call: RelOptRuleCall): Boolean = {
val join = call.rel(0).asInstanceOf[LogicalJoin]
-
- if (isInnerJoin(join)) {
- isSingleRow(join.getRight) || isSingleRow(join.getLeft)
- } else {
- false
- }
- }
-
- private def isInnerJoin(join: LogicalJoin) = {
- join.getJoinType == JoinRelType.INNER
+ isSingleRow(join.getRight) || isSingleRow(join.getLeft)
--- End diff --
The check should be
```
join.getJoinType match {
case JoinRelType.INNER =>
isSingleRow(join.getRight) || isSingleRow(join.getLeft)
case JoinRelType.LEFT =>
isSingleRow(join.getRight)
case JoinRelType.RIGHT =>
isSingleRow(join.getLeft)
case _ => false
}
```
We also need to pass the `JoinRelType` to the `DataSetSingleRowJoin`.
> Extend DataSetSingleRowJoin to support Left and Right joins
> -----------------------------------------------------------
>
> Key: FLINK-5256
> URL: https://issues.apache.org/jira/browse/FLINK-5256
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.2.0
> Reporter: Fabian Hueske
> Assignee: Anton Mushin
>
> The {{DataSetSingleRowJoin}} is a broadcast-map join that supports arbitrary
> inner joins where one input is a single row.
> I found that Calcite translates certain subqueries into non-equi left and
> right joins with single input. These cases can be handled if the
> {{DataSetSingleRowJoin}} is extended to support outer joins on the
> non-single-row input, i.e., left joins if the right side is single input and
> vice versa.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
