aws-nageshvh commented on code in PR #198:
URL:
https://github.com/apache/flink-connector-aws/pull/198#discussion_r2040332944
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/split/KinesisShardSplitSerializer.java:
##########
@@ -149,21 +186,29 @@ public KinesisShardSplit deserialize(int version, byte[]
serialized) throws IOEx
String startingHashKey;
String endingHashKey;
- if (version == CURRENT_VERSION) {
+ // startingHashKey and endingHashKey were added in V1
+ if (version >= 1) {
startingHashKey = in.readUTF();
endingHashKey = in.readUTF();
} else {
startingHashKey = "-1";
endingHashKey = "0";
}
+ boolean isFinished = false;
+ // isFinished was added in V2
+ if (version >= 2) {
Review Comment:
should this be version >=2 && in.available() > 0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
