aws-nageshvh commented on code in PR #198: URL: https://github.com/apache/flink-connector-aws/pull/198#discussion_r2040338148
########## flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/enumerator/tracker/SplitTracker.java: ########## Review Comment: In markAsFinished, should we mark the split as finished in knownSplits instead of removing them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
