aws-nageshvh commented on code in PR #198:
URL:
https://github.com/apache/flink-connector-aws/pull/198#discussion_r2040239209
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/enumerator/tracker/SplitTracker.java:
##########
@@ -159,6 +159,12 @@ private boolean
verifyAllParentSplitsAreFinished(KinesisShardSplit split) {
return allParentsFinished;
}
+ /**
+ * Checks if split with specified id is finished.
+ *
+ * @param splitId Id of the split to check
+ * @return true if split is finished, otherwise false
+ */
private boolean isFinished(String splitId) {
return !knownSplits.containsKey(splitId);
Review Comment:
We need to modify this method to check against the finished set?
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/enumerator/tracker/SplitTracker.java:
##########
@@ -159,6 +159,12 @@ private boolean
verifyAllParentSplitsAreFinished(KinesisShardSplit split) {
return allParentsFinished;
}
+ /**
+ * Checks if split with specified id is finished.
+ *
+ * @param splitId Id of the split to check
+ * @return true if split is finished, otherwise false
+ */
private boolean isFinished(String splitId) {
return !knownSplits.containsKey(splitId);
Review Comment:
We need to modify this method to check against the finished set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
