afedulov commented on code in PR #25656:
URL: https://github.com/apache/flink/pull/25656#discussion_r1898961111


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/FunctionITCase.java:
##########
@@ -1542,6 +1542,21 @@ void testUsingAddJar() throws Exception {
                 "drop function lowerUdf");
     }
 
+    @Test
+    void testUsingAddJarWithCheckpointing() throws Exception {
+        env().enableCheckpointing(100);
+        tEnv().executeSql(String.format("ADD JAR '%s'", jarPath));
+        ClassLoader contextClassLoader = 
Thread.currentThread().getContextClassLoader();
+        testUserDefinedFunctionByUsingJar(
+                env ->
+                        env.executeSql(
+                                String.format(
+                                        "create function lowerUdf as '%s' 
LANGUAGE JAVA",
+                                        udfClassName)),
+                "drop function lowerUdf");
+        
assertThat(contextClassLoader.equals(Thread.currentThread().getContextClassLoader()));
+    }

Review Comment:
   @snuyanzin I believe the key point here is that the changes that fix the 
issue for 2.0 have a much broader scope and it has been agreed that we will not 
backport features from 2.x into 1.x line (as discussed 
[here](https://github.com/apache/flink/pull/25656#discussion_r1852573652)), 
hence a more narrow fix is required.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to