gyfora commented on code in PR #921:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/921#discussion_r1905783988
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java:
##########
@@ -89,21 +89,41 @@ private static ConfigOptions.OptionBuilder
autoScalerConfig(String key) {
+ "seconds suffix, daily expression's
formation is startTime-endTime, such as 9:30:30-10:50:20, when exclude from
9:30:30-10:50:20 in Monday and Thursday "
+ "we can express it as 9:30:30-10:50:20
&& * * * ? * 2,5");
- public static final ConfigOption<Double> TARGET_UTILIZATION =
- autoScalerConfig("target.utilization")
+ public static final ConfigOption<Double> UTILIZATION_TARGET =
+ autoScalerConfig("utilization.target")
.doubleType()
.defaultValue(0.7)
-
.withFallbackKeys(oldOperatorConfigKey("target.utilization"))
+
.withDeprecatedKeys(autoScalerConfigKey("target.utilization"))
+ .withFallbackKeys(
+ oldOperatorConfigKey("utilization.target"),
+ oldOperatorConfigKey("target.utilization"))
.withDescription("Target vertex utilization");
- public static final ConfigOption<Double> TARGET_UTILIZATION_BOUNDARY =
- autoScalerConfig("target.utilization.boundary")
+ public static final ConfigOption<Double> UTILIZATION_TARGET_BOUNDARY =
+ autoScalerConfig("utilization.target.boundary")
Review Comment:
we should not rename this option also, the name you set is incorrect
anyways. Keys should not be prefixes of each other (not yaml compliant)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
